Handle staking limits in tBTC Depositor contract #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The staking flow in the dApp is asynchronous and there is a short period of time between a deposit funding transaction is made on Bitcoin chain and revealed to this contract.This limit is used to gain better control on the stakes queue, and reduce a risk of concurrent stake requests made in the dApp being blocked by another big deposit.
stBTC contract introduces limits for total deposits amount. Due to asynchronous manner of the staking flow, this contract needs to track balance of pending stake requests to ensure new stake request are not initialized if they won't be able to finalize. Amounts are gross deposit amounts in satoshi precision. It means, the value from Bitcoin funding transaction is used, including the fees taken by tBTC or Acre protocols.
The function should be used by dApp to validate maximum possible amount of the stake request. It takes into account limit set in the stBTC contract, maximum single stake limit and balance of pending stakes. The `initializeStakeRequest` function is not enforcing this limit, not to block the reveal deposit operation of the concurrent deposits made in the dApp in the short window between limit check, submission of Bitcoin funding transaction and stake request initialization. In case of an unfortunate coincidence of concurrent deposit request reaching the limit, the Acre protocol will work towards stake request finalization by raising the limit to let the queued stake request in.
|
Closing in favor of #253. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances #91.