Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MERGE PLEASE #118

Merged
merged 28 commits into from
Dec 14, 2023
Merged

MERGE PLEASE #118

merged 28 commits into from
Dec 14, 2023

Conversation

therossee
Copy link
Owner

No description provided.

therossee and others added 28 commits December 13, 2023 20:28
@therossee
Added files
50eb47a
@therossee
commit
1e9eb3f
@therossee
Filters prettied up
c723891
@therossee
insert/update proposal completed
f7d25b7
@therossee
Almost finished, student CV to fix
bcfcfb4
@therossee
Student CV fixed
652b64f
@therossee
code smells fixing
0eb50c0
@therossee
fixed popup apply proposal
2746249
@therossee
Merge branch 'main' into task/219-mobile-teacher
e9e61e4
@therossee
general fixes
766cfc9
@therossee
fixed filtering
b345563
@therossee
Merge remote-tracking branch 'origin/main' into task/218-mobile-student
bdbc8ec
@therossee
added copy proposal + various fixes
d369c3d
@therossee
minor fix
88574d9
@therossee
merging e2e
d925411
@therossee
fixed code smells MobStudentThesisProposals.jsx
b1d0847
@therossee
fixing code smells
cc8ff5a
@therossee
fixed error
243e604
@therossee
various code smells
24fdcfc
@therossee
attempt to reduce code duplication
67a0c99
@therossee
reduce code duplication
ad4ee97
@therossee
reduce code duplication
4be0b93
@therossee
reduce code duplication
638b993
@therossee
reduce code duplication
5b7ce63
@therossee
reduce code duplication
e5447d0
@therossee
reduce code duplication
7a84bb9
@therossee
reduce code duplication
1fb97f6
@therossee
reduce code duplication
27ac2f3
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

@therossee therossee changed the title DON'T MERGE, SOLVING CODE SMELLS MERGE PLEASE Dec 14, 2023
@Sylvie-Molinatto Sylvie-Molinatto merged commit 339ea5a into main Dec 14, 2023
2 checks passed
@therossee therossee deleted the task/218-mobile-student branch December 18, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sylvie-Molinatto Sylvie-Molinatto Sylvie-Molinatto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@therossee @Sylvie-Molinatto