zooming no longer screws with height tiny elements #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason this was a problem was that the images were less than 1 line height (20px). If an image is inline or inline-block then it will try to align itself with the text. If the image is smaller than 1 line height the parent container will be 1 line height and the image will be centered. When you zoom out the size of that 20px changes, but the percentage measurements don't. I fixed it by setting the line height to zero on every line that was affected and adjusting the top % accordingly.
I also took the initiative of generalizing the css a bit. I don't know if that was appropriate. I can undo that or do more of it in the future. I'd love to replace this with a javascript widget rather than several thousand lines of copy/pasted html and css.