New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomize + Customize no longer downloads and applies IPS #97

Merged

theonlydude merged 2 commits into theonlydude:master from chriscauley:randomize_and_customize

Sep 9, 2022

Collaborator

chriscauley commented Sep 1, 2022

The way the diff is represented is a little confusing. Basically I:

Pulled all the code involving applying the IPS and moved it into a new function applyIpsAndDownload (unfortunately because that was a longer passage than the first few lines of AjaxRandomizerCallComplete, it looks like I moved those lines instead)
Only call that function if data['ips'] is true
Remove data['ips'] on the backend if the frontend sent wantsCustomize=true

chriscauley added 2 commits

September 1, 2022 14:11


          Randomize + Customize no longer downloads and applies IPS before redi…

c37658f

…recting


          message from randomizer request to msg query parameter and show on ne…

20a5a28

…xt page

Collaborator Author

chriscauley commented Sep 3, 2022

I updated this to show any errors from the randomize step on the customize page after redirect.

Add ?msg=put anything here to the customize url and you'll get a message
Turn on scavenger and turn off varia hud to get a "varia hud forced to on" message
I then added "asdf" to the seed key to make sure the query string msg plays nice with the msg from python:

theonlydude merged commit 2b8a4f8 into theonlydude:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet