Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of objectives #95

Merged
merged 14 commits into from
Sep 9, 2022
Merged

Number of objectives #95

merged 14 commits into from
Sep 9, 2022

Conversation

chriscauley
Copy link
Collaborator

Instructions

  • The second commit (ca408ed) changed startTheTour to work with event and elementId. With event it searches for the parent or parents previous sibling with an Id and uses that as elementId. With elmentId (any string) it searches the steps to find the tour spot corresponding to that event. This will prevent us from needing to renumber everything next time we add a new tour element. I left this in a separate commit so it can be removed if someone has objections.
  • Selecting 1 "tourian objective" will hide the number of objectives. Selecting more than one will show it.
  • Clicking the dice disables nbObjective and sends "random" as the value.

@chriscauley
ability to specify a number of objectives
5c2758b
@chriscauley
Updating startTheTour to work with event or id and altering all oncli…
cdc1e70 
…ck events to not use index number
@chriscauley
hide nbObjectives row when there is only one selected objective
0d0a73d
@chriscauley
need to change the objectiveMultiSelect when page loads to trigger hi…
2ef957e 
…de/show of nbObjectiveVisibility
@chriscauley
Changing how nbObjectiveVisibility hide/show works
8e6f794
@chriscauley
standardizing objective and nbObjective to work like other parameters
bec3799
@chriscauley
objective and nbObjective now loading properly in the form
324338b
@chriscauley
reverting changes to how objective saves
5b8797f
@chriscauley
objectives should now be saving, generating, and loading properly in …
8ffe86d 
…randomizer page
@chriscauley
front end logic for storing and serving objective values
a1484d0
@chriscauley
self.vars.objectiveRandom is a string
836fe39
@chriscauley chriscauley force-pushed the number_of_objectives branch from e4236f7 to 836fe39 Compare August 29, 2022 16:58
@theonlydude theonlydude merged commit eca5a44 into theonlydude:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriscauley @theonlydude