Load inventory from game memory data for auto tracking - resolves #111 #113
Conversation
| } | ||
|
|
||
| currentState = dumpData["currentState"] | ||
| self.locDelta = 0 | ||
|
|
||
| for dataType, offset in dumpData["stateDataOffsets"].items(): |
There was a problem hiding this comment.
why are you doing a manual sort ?
we use python >= 3.6 which keep the order of insertion of keys in dictionaries.
|
hello, |
Sorry, I may have worded that unclearly. I meant if I used "Nothing" instead of "NoEnergy", the location is marked as visited as soon as it is viewed at all, even if e.g. it's out of reach and the player hasn't actually gotten the item yet. To clarify, this situation was happening because in a MW seed, the item at most locations is a MW item for another player statistically. This item is not recognized by the tracker of course, so it was falling back to putting "SpringBall" at every location which doesn't make sense. Initially I tried the "Nothing" item, but it behaved differently as mentioned. That's why I changed it to "NoEnergy" instead, so it wouldn't affect inventory.
Definitely! I tried to build off of that first, however running it locally the tracker page was crashing (saying it created a ticket ID on the back end but I couldn't find where this is). I presumed the master branch was just unstable and WIP, so I built off the production branch instead. I'll give the master branch another go. |
|
@theonlydude I'm trying to get the master branch running locally and it builds and runs under Docker, however when I visit the tracker page on my localhost, there are a number of static JS/CSS/image files that appear to be missing, including seemingly crucial ones like EDIT: I did figured out I was missing the |
|
I removed the web2py stuff recently, it looked non used (on my computer and beta). |
This changes the inventory population to read from the game memory as part of the current game state instead of populating based on visited locations and their contents. This makes it so e.g. Archipelago multiworld seeds will work properly where the location contents are items for other people most of the time.
In addition, I also changed the fallback item for such locations (including in race seeds) to be the "NoEnergy" item instead of spring ball as this doesn't mess with the actual inventory, and also doesn't disappear immediately upon viewing like the "Nothing" item does.
I attempted to do this on the current master branch, but the tracker page is crashing there so it's not usable for testing. I did it on the current production branch instead.