-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NonSingletCI Class, AP1roGSDGeneralizedSen-o Wfn #92
Open
q-pratz-chem
wants to merge
191
commits into
theochem:master
Choose a base branch
from
q-pratz-chem:nonsinglet-ap1rogen
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive in binding.cpp
…nd add_excited_dets
…lgorithm; exclude row i and col j corresponding to iparam
…t ii index for beta -> beta element
…ption of add_excited_dets
… and two_ao; update the add_row function by using this generalized hamiltonian
… are listed first; now initializing a nonsingletciwfn with FullCI wfn filled with excitation order 0 - ensuring HF, 1,2,3 and 4; Introduced sign_excite and sign_swap function to calculate the sign resulting from the ordering of the annihilation and creation operators used to generate the excited configurations; set first element of overlap to 1 corresponding to HF; if excitation_inds = -1 meaning empty then set the single and double permanents to zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces the following key features and fixes:
1.
NonSingletCI
ClassA new
NonSingletCI
class derived from theGenCIWfn
class is added to construct wavefunctions comprising configurations with unequal alpha and beta spin orbitals. Key highlights include:k
in updatingnword
ingenciwfn.cpp
, addressing an issue reported in PR #82 Update genciwfn.cpp #91.fill_hartreefock_det
: Constructs a single-bitstring representation of all spin orbitals (occupied, virtual, alpha, and beta).000011000011
, where the left (right) half represents beta (alpha) spin orbitals.add_excited_det
: Adds configurations based on a specified excitation order and reference configuration.add_row
function insparseop.cpp
tailored forNonSingletCI
to include matrix elements and a new `update' function.2. Geminal Wavefunction (
AP1roGSDGeneralizedSen-o
)Implements a new geminal wavefunction consisting of:
Implementation Details:
ap1rogen.cpp
file, based on theNonSingletCI
class.DetExcParamIndx
for efficient management of bitstring representations (determinants) and their associated parameter indices (singles and doubles).diff_ridders
function fromderivcheck.py
(which requires installation viapip install derivcheck
) currently fails due to an assertion error when comparing numerical and analytical derivatives.This PR lays the groundwork for future development and testing, particularly in the context of advanced geminal wavefunctions and their application.