Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quiz dark mode #342

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Fix Quiz dark mode #342

merged 4 commits into from
Mar 5, 2025

Conversation

seohyonkim
Copy link
Collaborator

Here I fixed the background colour of the quizzes in dark mode! Please merge if it looks good. Thank you!

@seohyonkim seohyonkim requested a review from Zethson February 28, 2025 15:35
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Zethson
Copy link
Member

Zethson commented Feb 28, 2025

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/jupyter_book/pdf.py", line 37, in _html_to_pdf
    from playwright.async_api import async_playwright, expect
ModuleNotFoundError: No module named 'playwright'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.13.2/x64/bin/jupyter-book", line 10, in <module>
    sys.exit(main())
             ~~~~^^
  File "/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/click/core.py", line 1161, in __call__
    return self.main(*args, **kwargs)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/click/core.py", line 1082, in main
    rv = self.invoke(ctx)
  File "/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/click/core.py", line 1697, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/click/core.py", line 1443, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/click/core.py", line 788, in invoke
    return __callback(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/jupyter_book/cli/main.py", line 317, in build
    builder_specific_actions(
    ~~~~~~~~~~~~~~~~~~~~~~~~^
        result, builder, OUTPUT_PATH, build_type, PAGE_NAME, click.echo
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/jupyter_book/cli/main.py", line 578, in builder_specific_actions
    html_to_pdf(output_path.joinpath("index.html"), path_pdf_output)
    ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/jupyter_book/pdf.py", line 32, in html_to_pdf
    asyncio.run(_html_to_pdf(html_file, pdf_file))
    ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/asyncio/runners.py", line 195, in run
    return runner.run(main)
           ~~~~~~~~~~^^^^^^
  File "/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/asyncio/base_events.py", line 725, in run_until_complete
    return future.result()
           ~~~~~~~~~~~~~^^
  File "/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/jupyter_book/pdf.py", line 39, in _html_to_pdf
    _error(
    ~~~~~~^
        "Generating PDF from book HTML requires the playwright package. "
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        "Install it first.",
        ^^^^^^^^^^^^^^^^^^^^
        ImportError,
        ^^^^^^^^^^^^
    )
    ^
  File "/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/jupyter_book/utils.py", line 48, in _error
    raise kind(box)
ImportError: 

Copy link

github-actions bot commented Feb 28, 2025

PR Preview Action v1.6.0

🧬 View preview of single-cell best practices at
https://theislab.github.io/single-cell-best-practices/pr-preview/pr-342/

Built to branch gh-pages at 2025-03-04 16:47 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Zethson Zethson merged commit 76dd78a into main Mar 5, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants