Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move from jquery to react js #331

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Manisha15
Copy link
Contributor

No description provided.

@Manisha15 Manisha15 force-pushed the extend_react_app branch 5 times, most recently from b9cf8ca to 785ebba Compare July 16, 2024 09:35
package.json Outdated Show resolved Hide resolved
webpack/components/ProxmoxComputeSelectors.js Outdated Show resolved Hide resolved
webpack/components/ProxmoxVmType.js Outdated Show resolved Hide resolved
webpack/components/ProxmoxVmType.js Outdated Show resolved Hide resolved
webpack/components/ProxmoxVmType.js Outdated Show resolved Hide resolved
Copy link
Contributor

@m-bucher m-bucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks 😁

app/helpers/proxmox_vm_attrs_helper.rb Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
@Manisha15 Manisha15 force-pushed the extend_react_app branch 14 times, most recently from 5e137e6 to 0426548 Compare July 23, 2024 14:05
@Manisha15 Manisha15 changed the title Move from jquery to react js feat: Move from jquery to react js Jul 23, 2024
@Manisha15 Manisha15 merged commit 3c18767 into theforeman:master Jul 23, 2024
22 checks passed
@Manisha15 Manisha15 deleted the extend_react_app branch July 23, 2024 15:22
hv_evmcs: __(
'Improve performance for nested virtualization. Only supported on Intel CPUs.'
),
aes: __('Activate AES instruction set for HW instruction'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the proxmox UI, it is actually:
"Activate AES instruction set for HW acceleration'"

'aes',
];

const cpuFlagDescriptions = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knit-pick: for some reason, the order in the UI differs from the order in the proxmox interface. But this is really, really minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants