Skip to content
This repository has been archived by the owner on Apr 14, 2024. It is now read-only.

upgrade phpstan to 0.12 and thecodingmachine/safe #11

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

bendavies
Copy link
Contributor

@bendavies bendavies commented Jan 23, 2020

Summary
Upgrade thecodingmachine/safe and phpstan+deps to the latest releases.

This allows using thecodingmachine/gotenberg-php-client:^6.1 in projects that also want use thecodingmachine/safe:^1.0 and phpstan/phpstan:^0.12+ thecodingmachine/phpstan-safe-rule^1.0.
Without this change, projects are stuck on phpstan/phpstan:^0.11

Test plan (required)

increased phpstan level in accordance with upgrade notes. make lint still passes.

Closing issues

Fixes #

Checklist

  • Have you followed the guidelines in our CONTRIBUTING guide?
  • Have you lint your code locally prior to submission (make lint)?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally (make tests)?
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@bendavies bendavies requested a review from gulien January 23, 2020 12:17
@gulien
Copy link
Contributor

gulien commented Jan 24, 2020

Thank you very much @bendavies

@gulien gulien merged commit ad6ea58 into thecodingmachine:master Jan 24, 2020
@gulien
Copy link
Contributor

gulien commented Jan 24, 2020

Version 6.1.1 is released 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants