Skip to content

Commit

Permalink
Merge pull request #69 from theappbusiness/bugfix/68/super-call
Browse files Browse the repository at this point in the history
Bugfix/68/super call
  • Loading branch information
KaneCheshire authored Jan 16, 2018
2 parents e44c3f6 + cd1634f commit 3213ad2
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
10 changes: 7 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## 7.2.1

- Fixes an issue where `super.start()` was being called unnecessarily.

## 7.2.0

- Adds the ability to cancel all requests from the resource service.
Expand Down Expand Up @@ -31,7 +35,7 @@

## 5.0.0

- The error from a failed `NetworkResponse` is now flattened and moved into the `NetworkServiceError` `couldNotParseModel` case to avoid nested switch statements:
- The error from a failed `NetworkResponse` is now flattened and moved into the `NetworkServiceError` `couldNotParseModel` case to avoid nested switch statements:

```swift
enum NetworkResponse<Model> {
Expand All @@ -50,7 +54,7 @@ enum NetworkResponse<Model> {
// New interface
func model(from data: Data) throws -> Model
```

- `JSONDictionaryResourceType` transformation function now throws on failure instead of returning `Model?`:

```swift
Expand All @@ -68,7 +72,7 @@ enum NetworkResponse<Model> {
// New interface
func model(from jsonArray: [Any]) throws -> Model
```

- Refactored network service
- Renamed `NetworkDataResourceService` to `GenericNetworkDataResourceService`, this is useful when using it with `ResourceOperation`
- New `NetworkDataResourceService` uses a generic fetching function
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ open class BaseAsynchronousOperation: Operation {
}

public final override func start() {
super.start()
self.isExecuting = true
main()
}

public final override func main() {
Expand Down
3 changes: 1 addition & 2 deletions TABResourceLoader.podspec
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Pod::Spec.new do |spec|
spec.name = 'TABResourceLoader'
spec.homepage = 'https://github.com/theappbusiness/TABResourceLoader'
spec.version = '7.2.0'
spec.version = '7.2.1'
spec.license = { :type => 'MIT' }
spec.authors = { 'Luciano Marisi' => '[email protected]' }
spec.summary = 'Framework for loading resources from a network service'
Expand All @@ -12,4 +12,3 @@ Pod::Spec.new do |spec|
spec.source_files = 'Sources/**/*.swift'
spec.ios.deployment_target = '8.0'
end

0 comments on commit 3213ad2

Please sign in to comment.