Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EBR-43: resolve sonar warnings #70

Merged
merged 3 commits into from
Apr 5, 2024
Merged

EBR-43: resolve sonar warnings #70

merged 3 commits into from
Apr 5, 2024

Conversation

915-Misan-Teodora
Copy link
Contributor

No description provided.

@915-Misan-Teodora 915-Misan-Teodora self-assigned this Apr 5, 2024
@@ -104,7 +105,8 @@

def test_dimensions_selection_update(tsw_tvb_data):
# simulate unchecking of some checkboxes
false_cb_idx = list(np.random.choice(76, size=3, replace=False))
rng = np.random.default_rng()

Check notice

Code scanning / SonarCloud

Results that depend on random number generation should be reproducible Low test

Provide a seed for this random generator. See more on SonarCloud
@@ -17,7 +18,8 @@
@pytest.fixture
def wrapper_np():
""" Returns an initialized Numpy wrapper with 3 dimensions """
numpy_array = np.random.rand(30000, 4, 50)
rng = np.random.default_rng()

Check notice

Code scanning / SonarCloud

Results that depend on random number generation should be reproducible Low test

Provide a seed for this random generator. See more on SonarCloud
@@ -97,8 +97,9 @@

def _generate_connectivity(no_of_regions):
labels = np.array(['sig ' + str(i) for i in range(no_of_regions)])
conn = connectivity.Connectivity(centres=np.random.rand(no_of_regions, 3),
rng = np.random.default_rng()

Check notice

Code scanning / SonarCloud

Results that depend on random number generation should be reproducible Low test

Provide a seed for this random generator. See more on SonarCloud
Copy link

sonarqubecloud bot commented Apr 5, 2024

@liadomide liadomide merged commit 911f8e6 into main Apr 5, 2024
4 of 6 checks passed
@liadomide liadomide deleted the EBR-43 branch April 5, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants