Close Browser #95
Merged
Close Browser #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphiffer
reviewed
Jul 24, 2024
| @@ -27,6 +27,22 @@ const deleteFolderRecursive = path => { | |||
| } | |||
| }; | |||
|
|
|||
| // This is an annoying hack to get around an issue in Puppeteer | |||
| // where the browser.close method hangs indefinitely | |||
| // See https://github.com/Sparticuz/chromium/issues/85#issuecomment-1527692751 | |||
There was a problem hiding this comment.
Is this the link you meant to put here? It talks about fixing the browser.close issue, but not the way you're doing it here (apparently by disabling the Chrome GPU function instead).
There was a problem hiding this comment.
ah yes, it's at a different point in the thread. I'll update the link
dphiffer
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
browser.close()was hanging indefinitely, leading to the lambda timing out. This 'solution' is in several Github Issue threads about the bug, such as this onePairs with Blacklight Lambda PR 73
Why are we doing this? How does it help us?
The recent updates to puppeteer and the collector types broke Blacklight on staging.
How/where should this be tested?
In staging, and locally, by running the collector and lambda and ensuring BL works
What are potential areas for future improvement? Are there any dependencies (especially on 3rd party code)?
Keep an eye on Puppeteer and Chromium releases, hopefully a future one will eliminate this bug
Have you done the following, if applicable:
(optional: add explanation between parentheses)