killing pages

the-markup · Jul 23, 2024 · 87af529 · 87af529
1 parent 7d25469
commit 87af529
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/collector.ts b/src/collector.ts
@@ -16,7 +16,7 @@ import { dedupLinks, getLinks, getSocialLinks } from './pptr-utils/get-links';
 import { autoScroll, fillForms } from './pptr-utils/interaction-utils';
 import { setupSessionRecordingInspector } from './session-recording';
 import { setUpThirdPartyTrackersInspector } from './third-party-trackers';
-import { clearDir } from './utils';
+import { clearDir, closeBrowser } from './utils';
 
 export type CollectorOptions = Partial<typeof DEFAULT_OPTIONS>;
 
@@ -222,7 +222,7 @@ export const collect = async (inUrl: string, args: CollectorOptions) => {
         // Return if the page doesnt load
         if (loadError) {
             console.log("browser close 1");
-            await browser.close();
+            await closeBrowser(browser);
             if (typeof userDataDir !== 'undefined') {
                 clearDir(userDataDir, false);
             }
@@ -306,7 +306,7 @@ export const collect = async (inUrl: string, args: CollectorOptions) => {
 
         console.log('closing browser 1');
         console.log(browser);
-        await browser.close();
+        await closeBrowser(browser);
         console.log('... done closing browser 1');
         if (typeof userDataDir !== 'undefined') {
             clearDir(userDataDir, false);

diff --git a/src/utils.ts b/src/utils.ts
@@ -27,6 +27,17 @@ const deleteFolderRecursive = path => {
     }
 };
 
+export const closeBrowser = async (browser) => {
+    const childProcess = browser.process();
+    if (childProcess) {
+        console.log("killing child process, ", childProcess);
+        childProcess.kill(9);
+    }
+    console.log("closing browser");
+    await browser.close();
+    console.log("done closing browser");
+};
+
 export const clearDir = (outDir, mkNewDir = true) => {
     if (fs.existsSync(outDir)) {
         deleteFolderRecursive(outDir);