Issue # 43 - A user should be able to be directed to a list and view a list name #61
Conversation
|
Visit the preview URL for this PR (updated for commit 5aa62d6): https://tcl-77-smart-shopping-list--pr61-ma-view-list-name-ywdjj24f.web.app (expires Sun, 13 Oct 2024 18:22:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72 |
eternalmaha
changed the title
|
Everything appears to be fine so far. Only issue is fetching the data to render in Lists. I realized what the issue was. The list data is passed and fetched properly in Home.tsx and AuthenticatedHome.tsx. The issue was that our fetched items have a different data structure than what our ListItemModel type expects. Our ListItemModel type is expecting the item.quantity property but our fetched items do not have that. When I commented out the itemQuantity defined property in our ListItemModelType, the List component is able to fetch the ListItem data properly…now to work on defining itemQuantity properly in a more appropriate way, which is probably a separate issue |
|
Per the conversations in slack with the team, we have come to the conclusion that the issue does not happen with new lists!!! That makes so much sense now that i think about it. Those old lists had already been created with their defined parameters without the item quantity parameter which is why they lists failed to fetch those old list items. I will go ahead and mark my PR ready for review to then merge my PR. Thank you ever for the perception! |
eternalmaha
requested review from
bbland1,
alex-andria,
zahrafalak and
RossaMania
and removed request for
bbland1
|
|
||
| // The document's id is not in the data, | ||
| // but it is very useful, so we add it to the data ourselves. | ||
| item.id = docSnapshot.id; | ||
|
|
||
| const decoded = ListItemModel.decode(item); | ||
| if (isLeft(decoded)) { | ||
| console.error("Validation failed for item:", item); |
There was a problem hiding this comment.
Don't forget to remove all console logs!
Description
Reopening up a new PR again finally closing out Issue #43 after it was opened again and a reverted PR was merged . Fixed bug issues of duplicate home page rendering and list nav bar still appearing.
In this PR, users should be able to directly navigate to lists after clicking list buttons and list name should appear at the top of list view. This PR also highlighted a new point: list item data will only fetch new lists since our ListItemModel Type was strategically updated in a previously merged PR to include the newly defined parameter: itemQuantity. Incredible team work and insight from the whole team to uncover this new detail!
Related Issue
closes #43
Acceptance Criteria
Type of Changes
enhancementUpdates
list.fetches.data.from.new.lists.mov
Testing Steps / QA Criteria