-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.4.3e-dev #iain-dev->#stage #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch-vehicle-command->iain-dev
raphmur
approved these changes
Feb 7, 2025
baylanger
reviewed
Feb 8, 2025
baylanger
reviewed
Feb 8, 2025
baylanger
reviewed
Feb 8, 2025
baylanger
reviewed
Feb 8, 2025
baylanger
reviewed
Feb 8, 2025
Let me know if either of you have further comments or can I resolve the conversations? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.4.3e-dev
Development release to improve robustness, and fix various things identified in previous dev releases:
Terminate tesla-control processes that run longer than $TC_KILL_TIMEOUT seconds. Discussion: #142
Wait for tesla-control processes to finish before moving on with the sequence. There is now no need to sleep after each command is sent, so the $BLE_CMD_RETRY_DELAY environment variable is deprecated. Credit to BogdanDIA for this. https://github.com/BogdanDIA
Don't make body-controller-state calls every $PS_LOOP_DELAY as it's too hard on the bluetooth. The preferred means of determining presence is confirmed as the original passive bluetooth scanning, not body controller state. Awake sensor is not now updated every $PS_LOOP_DELAY secs but only when state is read or a command is sent
Function teslaCtrlSendCommand() is deprecated in favour of the improved sendBLECommand()
Patch vehicle-command to allow BT versions <=5.0, and to specify the hci device number using environment variable $BLE_HCI_NUM. Credit again to BogdanDIA. Discussion: #125
NEW Features:
New poll_state_loop delay and tesla-command timeout environment variables added, to allow the user to fine tune settings which may affect speed versus robustness
Environment Variable $IMMEDIATE_UPDATE. If this is set to true (default), then after a command has been successfully sent to the car, the state_topic for the relevant entity is immediately updated. If set to false, this doesn't happen automatically, the state_topic is updated at the next polling occurence or a force update button press. See tesla-local-control/tesla_ble_mqtt_docker#82
Fixes:
Standardize on Celsius #144 (_core). This deprecates the $TEMPERATURE_UNIT_FAHRENHEIT environment variable, and removes associated code. Thanks to https://github.com/aneisch for the suggestion and for modding and testing the code. In doing so, he found an error in the HA MQTT Number entity code home-assistant/core#135619
Odometer sensor now has a device_class defined, so units can be selected in the Settings dialog for the entity in HA tesla-local-control/tesla_ble_mqtt_docker#79
Rear heated seats didn't respond to commands