Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

Commit

Permalink
Enabled URL checking and cleaning
Browse files Browse the repository at this point in the history
Fluidbox will throw a warning and refuse to proceed if whitespace
characters are present in the URL. As HTML collapses multiple
whitespaces into one, it is impossible to determine whether the
reference file contains collapsed or uncollapsed multiple whitespaces.
Whitespaces must be escaped manually.

On the other hand, Fludibox throws a warning but proceeds with expected
behaviour when encountering the following character set (expressed in
regex): ["'\(\)]. The reason being that these characters directly
interfere with jQuery and therefore need to be replaced anyway.
  • Loading branch information
terrymun committed Dec 12, 2015
1 parent b71a025 commit 5a8e729
Show file tree
Hide file tree
Showing 3 changed files with 42 additions and 7 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Special thanks to the following stellar folks who has helped majorly in making F
- [@benwhilhelm](https://github.com/benwilhelm) for suggesting the immedate open option in Fluidbox. Ben has author a PR, but I have found some issues that I cannot resolve. However, I have adopted his idea and simplified the implementation in **v1.4.3**.
- [@jaechick](https://github.com/jaechick) for creating the LESS file for Fluidbox stylesheet, even though the LESS file is removed from the project as the stylesheet is now being preprocessed by SASS.
- [@_mattbailey](https://twitter.com/_mattbailey) for his [awesome guide towards integrating Grunt into a project](http://mattbailey.io/a-beginners-guide-to-grunt-redux/). This has made building Fluidbox a lot easier.
- [@DJDavid98](https://github.com/DJDavid98) for enabling proper parsing of backgorund image URLs. Note that the URL provided still has to be [RFC3986](http://www.ietf.org/rfc/rfc3986.txt)-compliant.

In addition, a shoutout to:

Expand Down
2 changes: 1 addition & 1 deletion dist/js/jquery.fluidbox.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5a8e729

Please sign in to comment.