Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Google Zone Shortname #52

Closed
wants to merge 6 commits into from
Closed

feat: add support for Google Zone Shortname #52

wants to merge 6 commits into from

Conversation

r-teller
Copy link

@r-teller r-teller commented Dec 7, 2023

  • Add support for returning zone shortname
  • Add missing region "me-central2"

@r-teller
Features
ba4af81 
- Add support for returning zone shortname
- Add missing region "me-central2"
@r-teller r-teller requested a review from a team as a code owner December 7, 2023 20:10
@r-teller r-teller changed the title Features feat: add support for Google Zone Shortname Dec 7, 2023
@r-teller
Copy link
Author

@apeabody / @morgante any chance you can approve this?

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

Thanks @r-teller!

You should be able to view the lint results in GitHub, here is the relevant section of the INT test:

-----> Verifying <additional-zones-gcp>...
[...]
  outputs
     ×  additional zones should return valid short names
     
     expected: "usc2a"
          got: nil
     
     (compared using ==)

     ×  a specific additional_zone shortname should be output
     
     expected: "usc2a"
          got: ""
     
     (compared using ==)

@r-teller
Update main.tf
15c9d4a 
commenting out to work around race condition for features that do not exist during validation
@apeabody
Copy link
Contributor

/gcbrun

apeabody
apeabody reviewed Jan 12, 2024
View reviewed changes
examples/simple_example/main.tf
version = "~> 0.7"
source = "../.."
#source = "terraform-google-modules/utils/google"
#version = "~> 0.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This is done automatically by module-swapper during the lint and int tests

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Mar 12, 2024
@github-actions github-actions bot closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody left review comments

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-teller @apeabody