Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support optional health_checks #472

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

muskoxleader
Copy link

Currently, the serverless_negs module creates the google_compute_backend_service resource. This is where google_compute_health_check resources should be attached, however, this interface isn't exposed via var.backends.

This PR allows invokers of the serverless_negs module to use health checks.

@muskoxleader muskoxleader requested review from imrannayer, q2w and a team as code owners November 21, 2024 19:23
Copy link

google-cla bot commented Nov 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@imrannayer
Copy link
Collaborator

imrannayer commented Dec 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants