chore: update connection metadata and url_map creation in modules/frontend #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q2w
force-pushed
the
update-1111
branch
2 times, most recently
from
5b7ec53 to
2e2cba8
Compare
q2w
force-pushed
the
update-1111
branch
3 times, most recently
from
1c86f6a to
104cb26
Compare
Merged
q2w
force-pushed
the
update-1111
branch
3 times, most recently
from
22564fa to
4a7ac4e
Compare
q2w
changed the title
bharathkkb
approved these changes
Jan 15, 2025
| - [8.X -> 9.0](https://github.com/terraform-google-modules/terraform-google-lb-http/blob/master/docs/upgrading_to_v9.0.md) | ||
| - [9.X -> 10.0](https://github.com/terraform-google-modules/terraform-google-lb-http/blob/master/docs/upgrading_to_v10.0.md) | ||
| - [10.X -> 11.0](https://github.com/terraform-google-modules/terraform-google-lb-http/blob/master/docs/upgrading_to_v11.0.md) | ||
| Current version is 9.0. Upgrade guides: |
There was a problem hiding this comment.
This seems erroneous - latest version is 12?
There was a problem hiding this comment.
This is autogenerated! If i don't update this the lint test is failing!
There was a problem hiding this comment.
Hi @q2w @bharathkkb - Looks like this file is generated from a template, please update here: https://github.com/terraform-google-modules/terraform-google-lb-http/blob/main/autogen/README.md#compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates metadata files and updated connection metadata in modules/backend
This PR also update url_map creation login within modules/frontend. Before this change if there was no host configured as default (
*), the url_map creation would fail.