Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Add support for both 20.04 and 22.04 in package and release workflow #17755

Merged
merged 15 commits into from
Feb 18, 2025

Conversation

ayerofieiev-tt
Copy link
Member

@ayerofieiev-tt ayerofieiev-tt commented Feb 8, 2025

Ticket

None

Problem description

Need both 20.04 and 22.04 wheels for Pytorch backend

What's changed

Uploads
ttnn-0.0.dev1+any-cp310-cp310-linux_x86_64.whl

ttnn-0.0.dev1+any-cp38-cp38-linux_x86_64.whl

See how version is wrong - 0.0.dev1

Checklist

@ayerofieiev-tt ayerofieiev-tt requested a review from a team as a code owner February 8, 2025 05:56
@ttmchiou
Copy link
Contributor

it looks like these changes also disables all the model perf and device perf tests here?
is this intentional?

@ayerofieiev-tt
Copy link
Member Author

@ttmchiou can you clarify why do you think so? I expect they keep running, but instead of running on both 22.04 and 20.04, they only run on 20.04 as before.

@ttmchiou
Copy link
Contributor

https://github.com/tenstorrent/tt-metal/actions/runs/13213125243

It looks like in this run that all the demo/perf pipelines all are in a pending state. Clicking into a run says the job is skipped?
Related to the if condition change for pipelines i would assume to maintain that they continue running for 20.04.

@blozano-tt
Copy link
Contributor

https://github.com/tenstorrent/tt-metal/actions/runs/13213125243

It looks like in this run that all the demo/perf pipelines all are in a pending state. Clicking into a run says the job is skipped? Related to the if condition change for pipelines i would assume to maintain that they continue running for 20.04.

@ttmchiou good catch.

@ayerofieiev-tt
I think there is something wrong with this logic:

if: ${{ contains(needs.build-artifact.*.outputs.version, '20.04') }}

version is not an output of build-artifact.

@ayerofieiev-tt
Copy link
Member Author

You are right. Thanks!

Any advice on how this can be fixed?

@ttmchiou
Copy link
Contributor

did you try the recommendations I commented on?

@ayerofieiev-tt
Copy link
Member Author

@ttmchiou if you refer to this comment #17755 (comment) I am not sure how to specify those jobs to only run on 20.04
I assume maybe I can simply remove the condition.

@ayerofieiev-tt
Copy link
Member Author

@ttmchiou , @blozano-tt , fixed.

But we need to fix the naming asap. This "dev13" thing is painful. I was not able to find where its coming from, but it is not coming from this PR, it is the current state of main basically.

ttnn-0.56.0rc24.dev13+any-cp310-cp310-linux_x86_64.whl

ttnn-0.56.0rc24.dev13+any-cp38-cp38-linux_x86_64.whl

@blozano-tt
Copy link
Contributor

@ttmchiou , @blozano-tt , fixed.

But we need to fix the naming asap. This "dev13" thing is painful. I was not able to find where its coming from, but it is not coming from this PR, it is the current state of main basically.

ttnn-0.56.0rc24.dev13+any-cp310-cp310-linux_x86_64.whl

ttnn-0.56.0rc24.dev13+any-cp38-cp38-linux_x86_64.whl

We fixed all of our issues on main. Thanks to @dimitri-tenstorrent.
I merged main into this PR, and resolved the merge conflicts.

Copy link
Contributor

@blozano-tt blozano-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to block this until we can confirm that it doesn't break all-post-commit and all the workflows that depend on build-artifact.

I think the change to the build-artifact artifact upload will break downstream workflows that download the artifact.

Yeah: This breaks CI

@afuller-TT you highlighted a while back that we need to fix artifact naming to support having multiple artifacts at play in a single workflow...

I am thinking build-artifact workflow should output an "artifact-name" string, for downstream workflows. Just like you were planning for docker-image.

@blozano-tt blozano-tt self-requested a review February 18, 2025 22:58
@blozano-tt blozano-tt changed the title Add support for both 20.04 and 22.04 in package and release workflow [skip ci] Add support for both 20.04 and 22.04 in package and release workflow Feb 18, 2025
@ayerofieiev-tt ayerofieiev-tt merged commit 0dacb45 into main Feb 18, 2025
34 of 47 checks passed
@ayerofieiev-tt ayerofieiev-tt deleted the ay/2204_package_and_release branch February 18, 2025 22:59
dgomezTT pushed a commit that referenced this pull request Feb 19, 2025
… workflow (#17755)

### Ticket
None

### Problem description
Need both 20.04 and 22.04 wheels for Pytorch backend

### What's changed
Uploads

[ttnn-0.0.dev1+any-cp310-cp310-linux_x86_64.whl](https://github.com/tenstorrent/tt-metal/releases/download/v0.56.0-rc16/ttnn-0.0.dev1+any-cp310-cp310-linux_x86_64.whl)



[ttnn-0.0.dev1+any-cp38-cp38-linux_x86_64.whl](https://github.com/tenstorrent/tt-metal/releases/download/v0.56.0-rc16/ttnn-0.0.dev1+any-cp38-cp38-linux_x86_64.whl)


See how version is wrong - 0.0.dev1


### Checklist
- [ ] [Package and
release](https://github.com/tenstorrent/tt-metal/actions/runs/13296926538)
- [ ] [All
Post-Commit](https://github.com/tenstorrent/tt-metal/actions/runs/13296914267)

---------

Co-authored-by: Bryan Wilder Field Lozano <[email protected]>
hschoi4448 pushed a commit that referenced this pull request Feb 20, 2025
… workflow (#17755)

### Ticket
None

### Problem description
Need both 20.04 and 22.04 wheels for Pytorch backend

### What's changed
Uploads

[ttnn-0.0.dev1+any-cp310-cp310-linux_x86_64.whl](https://github.com/tenstorrent/tt-metal/releases/download/v0.56.0-rc16/ttnn-0.0.dev1+any-cp310-cp310-linux_x86_64.whl)



[ttnn-0.0.dev1+any-cp38-cp38-linux_x86_64.whl](https://github.com/tenstorrent/tt-metal/releases/download/v0.56.0-rc16/ttnn-0.0.dev1+any-cp38-cp38-linux_x86_64.whl)


See how version is wrong - 0.0.dev1


### Checklist
- [ ] [Package and
release](https://github.com/tenstorrent/tt-metal/actions/runs/13296926538)
- [ ] [All
Post-Commit](https://github.com/tenstorrent/tt-metal/actions/runs/13296914267)

---------

Co-authored-by: Bryan Wilder Field Lozano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants