#16339: let DispatchMemMap get created with custom DispatchSettings
#17449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhuang-tt
force-pushed
the
nhuang/dispatch-mem-map-custom-settings
branch
from
0a43384 to
b5f8b1b
Compare
nhuang-tt
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal,
ubcheema,
cfjchu and
omilyutin-tt
as code owners
nhuang-tt
changed the title
DispatchMemMap with custom settingsDispatchMemMap get passed in with custom DispatchSettings
nhuang-tt
changed the title
DispatchMemMap get passed in with custom DispatchSettingsDispatchMemMap get created with custom DispatchSettings
omilyutin-tt
requested changes
Jan 31, 2025
tests/tt_metal/tt_metal/dispatch/dispatch_util/test_dispatch_settings.cpp
Outdated
Show resolved
Hide resolved
nhuang-tt
force-pushed
the
nhuang/dispatch-mem-map-custom-settings
branch
3 times, most recently
from
43146c2 to
841e871
Compare
nhuang-tt
force-pushed
the
nhuang/dispatch-mem-map-custom-settings
branch
from
841e871 to
ed05ec9
Compare
nhuang-tt
force-pushed
the
nhuang/dispatch-mem-map-custom-settings
branch
4 times, most recently
from
d3f8e16 to
66c0ca0
Compare
nhuang-tt
force-pushed
the
nhuang/dispatch-mem-map-custom-settings
branch
5 times, most recently
from
f6f60f0 to
91c795e
Compare
omilyutin-tt
approved these changes
Feb 3, 2025
nhuang-tt
force-pushed
the
nhuang/dispatch-mem-map-custom-settings
branch
from
e472697 to
dee037f
Compare
- Previously DispatchMemMap was hardcoded to use only the default settings - DispatchMemMap initialized using a DispatchSettings object with a core_type & num_hw_cqs combo - Singleton access to DispatchSettings. Buffer sizes may be customized during device initialization
nhuang-tt
force-pushed
the
nhuang/dispatch-mem-map-custom-settings
branch
from
dee037f to
6e6fa4d
Compare
tt-dma
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#16339
Problem description
DispatchMemMaphardcoded to use default settings.Need to be able to use different settings for tests like Test Prefetcher and Test Dispatcher.
Need to be able to use settings that could be loaded from a file along with the FD topology.
What's changed
Singleton interface to customize
DispatchSettings. Singleton will persist settings for variouscore_type/num_hw_cqcombos. Callers can get / reset / modify the settings for the core type / cq combo.DispatchMemMapwill be created using theDispatchSettings, which may have been customized.NOTE: Custom
DispatchSettingsshould be setup early. E.g., during Device or DevicePool initializationThe
DispatchSettingswill be persisted for each {CoreType, #CQs}.DispatchMemMapwith a different CoreType can happen, e.g., during FD Topology init it needs the MemMap for WORKER AND ETH cores (tunnelers).Test
CommandQueueSingleCardFixture.TestDispatchSettingsMutationsChecklist
TGG: https://github.com/tenstorrent/tt-metal/actions/runs/13130873636
APC: https://github.com/tenstorrent/tt-metal/actions/runs/13130870905
T3K: https://github.com/tenstorrent/tt-metal/actions/runs/13130877271