Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13856: update gelu_bw op documentation on bfloat8_b limitations #17407

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KalaivaniMCW
Copy link
Contributor

@KalaivaniMCW KalaivaniMCW commented Jan 30, 2025

Ticket

Link to Github Issue #13856

Problem description

Since gelu_bw ops uses ttnn::exp in its implementation, beyond a certain input range the output is very a large number and will cause flushing of nearby values. bfloat8_b is a block format datatype with shared exponent for every 16 consecutive elements.
https://docs.tenstorrent.com/tt-metal/latest/ttnn/ttnn/tensor.html#limitation-of-bfloat8-b
For more details: link

What's changed

Updated docs on the limitations of using bfloat8_b dtype for the gelu_bw and bias_gelu_bw ops

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

@KalaivaniMCW KalaivaniMCW marked this pull request as ready for review January 31, 2025 15:58
@KalaivaniMCW KalaivaniMCW changed the title #13856: update gelu_bw ops on bf8b limitations #13856: update gelu_bw op documentation on bf8b limitations Jan 31, 2025
@KalaivaniMCW KalaivaniMCW changed the title #13856: update gelu_bw op documentation on bf8b limitations #13856: update gelu_bw op documentation on bfloat8_b limitations Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ttnn.bias_gelu_bw unary low PCC
4 participants