Adding Expand and Re-architect Repeat #17270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amorrisonTT
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
yan-zaretskiy,
rfurko-tt,
cfjchu,
TT-BrianLiu,
razorback3,
dongjin-na,
bbradelTT,
ntarafdar,
sjameelTT,
jaykru-tt,
yugi957,
jvegaTT,
llongTT and
nardoTT
as code owners
amorrisonTT
force-pushed
the
amorrison/repeat-op
branch
2 times, most recently
from
250fb9d to
bc0e4ed
Compare
|
I converted this PR to draft while it is WIP, hoping that it doesn't keep triggering CI. |
amorrisonTT
force-pushed
the
amorrison/repeat-op
branch
2 times, most recently
from
10404b9 to
4931891
Compare
amorrisonTT
changed the title
amorrisonTT
force-pushed
the
amorrison/repeat-op
branch
from
4931891 to
c936d55
Compare
jvegaTT
reviewed
Jan 29, 2025
jvegaTT
reviewed
Jan 29, 2025
jvegaTT
reviewed
Jan 29, 2025
amorrisonTT
force-pushed
the
amorrison/repeat-op
branch
from
453ea92 to
5bbb2ac
Compare
TT-BrianLiu
approved these changes
Feb 1, 2025
bbradelTT
approved these changes
Feb 3, 2025
amorrisonTT
force-pushed
the
amorrison/repeat-op
branch
2 times, most recently
from
d15055a to
7e50126
Compare
amorrisonTT
force-pushed
the
amorrison/repeat-op
branch
from
7e50126 to
6fa7f58
Compare
dmakoviichuk-tt
approved these changes
Feb 4, 2025
amorrisonTT
force-pushed
the
amorrison/repeat-op
branch
from
6fa7f58 to
2e626a1
Compare
amorrisonTT
force-pushed
the
amorrison/repeat-op
branch
from
2e626a1 to
59edea0
Compare
amorrisonTT
force-pushed
the
amorrison/repeat-op
branch
from
59edea0 to
945dd77
Compare
kkabilarTT
added a commit
that referenced
this pull request
Feb 14, 2025
This reverts commit b45f5a2.
kkabilarTT
added a commit
that referenced
this pull request
Feb 14, 2025
This reverts commit b45f5a2.
hschoi4448
pushed a commit
that referenced
this pull request
Feb 20, 2025
### Ticket [Link to Github Issue ](#17243 (comment)) #16701 #14443 #13587 #16698 ### Problem description Original repeat implementation was bad and didn't work in many cases, see issues. ### What's changed • Shiny new `repeat` op kernel written by @jvegaTT • C++ plumbing for `repeat` op • `expand` op refactored to use new `repeat` op • old `repeat` op deleted • Calls to `repeat` replaced with new op in a couple of places • Unit tests updated and expanded ### Checklist - [ ] Post commit CI passes. [Submitted again](https://github.com/tenstorrent/tt-metal/actions/runs/13163866908) - [ ] Blackhole Post commit (if applicable) - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [ ] **(For models and ops writers)** Full [new models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) tests passes - [x] New/Existing tests provide coverage for changes --------- Co-authored-by: Juan Camilo Vega <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
#16701
#14443
#13587
#16698
Problem description
Original repeat implementation was bad and didn't work in many cases, see issues.
What's changed
• Shiny new
repeatop kernel written by @jvegaTT• C++ plumbing for
repeatop•
expandop refactored to use newrepeatop• old
repeatop deleted• Calls to
repeatreplaced with new op in a couple of places• Unit tests updated and expanded
Checklist