Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shard and physical height mismatch in ttnn.convert_to_chw tests #17258

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

esmalTT
Copy link
Contributor

@esmalTT esmalTT commented Jan 28, 2025

Ticket

What's changed

  • Fix validation in pytest tests/ttnn/unit_tests/operations/test_convert_to_chw.py::test_convert_to_chw
  • Consolidate CB indices in ttnn.convert_to_chw

Checklist

Note: The failure was only in a single test, and this test is confirmed to be now passing. The only model using this op is UNet Shallow, its tests are passing.

@esmalTT esmalTT self-assigned this Jan 28, 2025
@esmalTT esmalTT mentioned this pull request Jan 29, 2025
5 tasks
@esmalTT esmalTT force-pushed the esmal/fix-convert_to_chw branch 2 times, most recently from c89b99a to 6d14154 Compare January 29, 2025 18:21
@esmalTT esmalTT merged commit bb87875 into main Jan 30, 2025
209 of 220 checks passed
@esmalTT esmalTT deleted the esmal/fix-convert_to_chw branch January 30, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants