Upgrade bower and node to latest versions #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also changes the lockfile to v2
bower orbicular#1.0.3 not-cached https://github.com/cotag/orbicular.git#1.0.3 bower orbicular#1.0.3 resolve https://github.com/cotag/orbicular.git#1.0.3 bower orbicular#1.0.3 download https://github.com/cotag/orbicular/archive/v1.0.3.tar.gz bower orbicular#1.0.3 extract archive.tar.gz bower orbicular#1.0.3 EINVALID Failed to read /tmp/liam/bower/bf64b169cab316427e9c8e21e7c01f69-1887481-9lwDrO/bower.json Additional error details: The "main" field has to be either an Array or a String
hut8
commented
Jul 16, 2022
hut8
commented
Jul 16, 2022
hut8
commented
Jul 16, 2022
hut8
commented
Jul 16, 2022
|
@joshjordan this should be good to go. Some of the tests changed because the behavior of bower changed. If you think this is bad, I can try a workaround, but it seems to me like a lot of those tests were added because there was very unexpected behavior. Now bower matches more expected behavior, so that's why I changed the tests instead of patching rails-assets to re-implement the strange bower behavior. Your thoughts are welcome. After this, I'll re provision the server with a new, supported OS. |
|
I changed my mind; I'm making the tests the same as the original |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves major security issue in #485