Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak .result() doc #706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tweak .result() doc #706

wants to merge 1 commit into from

Conversation

dandavison
Copy link
Contributor

No description provided.

@dandavison dandavison requested a review from a team as a code owner December 16, 2024 20:10
Comment on lines +1234 to +1236
fetched, until the most recent one is found. If false, return
the result from the first run targeted by the request if that run
ends in a result, otherwise raise an exception.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fetched, until the most recent one is found. If false, return
the result from the first run targeted by the request if that run
ends in a result, otherwise raise an exception.
fetched, until the most recent one is found. If false, return
the result or raise an exception for the single run targeted
by the request without traversing into other runs.

Not necessarily better, just "otherwise raise an exception" isn't really clear that this is because in other cases an exception may causes run traversal. But don't have to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants