Update SetWorkerDeploymentCurrentVersionRequest to have ignore_missing_task_queues #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlydf
approved these changes
Jan 31, 2025
Comment on lines
2019
to
2030
| // Optional. By default, false. If true, this operation will succeed even if the new version does not have | ||
| // all the task-queues which were present in the previously set current version. If set to false, | ||
| // any of the following conditions should hold true before the new version is set as current: | ||
| // | ||
| // - The new version must have all the task-queues which were present in the previously set current version. | ||
| // | ||
| // - If there are any missing task queues from this new version, all of them should have a current deployment version set. In other | ||
| // words, these task queues should not be unversioned. (TaskQueueVersioningInfo.current_version should not be empty && | ||
| // TaskQueueVersioningInfo.current_version.build_id != "__unversioned__") | ||
| // | ||
| // - If there are any missing task queues from this new version, all of them should have an add_rate of 0 since | ||
| // this would signify that there are no backlogged tasks being added in these queues. (see TaskQueueStats.tasks_add_rate) |
There was a problem hiding this comment.
Suggested change
| // Optional. By default, false. If true, this operation will succeed even if the new version does not have | |
| // all the task-queues which were present in the previously set current version. If set to false, | |
| // any of the following conditions should hold true before the new version is set as current: | |
| // | |
| // - The new version must have all the task-queues which were present in the previously set current version. | |
| // | |
| // - If there are any missing task queues from this new version, all of them should have a current deployment version set. In other | |
| // words, these task queues should not be unversioned. (TaskQueueVersioningInfo.current_version should not be empty && | |
| // TaskQueueVersioningInfo.current_version.build_id != "__unversioned__") | |
| // | |
| // - If there are any missing task queues from this new version, all of them should have an add_rate of 0 since | |
| // this would signify that there are no backlogged tasks being added in these queues. (see TaskQueueStats.tasks_add_rate) | |
| // Optional. By default this protects against accidentally removing a task queue from the current deployment version. | |
| // If false, one of the following conditions must hold true for the new version to be set as current: | |
| // - The new current version must have all the task-queues that are present in the existing current version. | |
| // or | |
| // - If the new current version is missing task queues that are present in the existing current version, | |
| // each missing task queue should have either: | |
| // - A current deployment version set, signifying that the task queue has been added to another deployment. | |
| // or | |
| // - An add_rate of 0, signifying that there are no backlogged tasks being added in these queues. (see TaskQueueStats.tasks_add_rate) | |
| // If true, this operation will succeed even if the new current version does not have all the task-queues that were | |
| // present in the existing current version. |
What do you think of this structure?
There was a problem hiding this comment.
I quite like this - thanks for proposing!
Merged
Shivs11
added a commit
that referenced
this pull request
Jan 31, 2025
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** - Similar to #541 in that this flag should also be added to the ramping request <!-- Tell your future self why have you made these changes --> **Why?** <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.
What changed?
Why?
Breaking changes
Server PR