Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve versioning timestamps #538

Closed
wants to merge 1 commit into from
Closed

Improve versioning timestamps #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Improve timestamps
  • Loading branch information
@carlydf
carlydf committed Jan 30, 2025
commit 9400a988dbc9eb615d79c9180665987d98dad3a9
6 changes: 3 additions & 3 deletions openapi/openapiv2.json
View file
Original file line number Diff line number Diff line change
@@ -11867,10 +11867,10 @@
"format": "date-time",
"description": "Last time ramping version was changed. Not updated if only the ramp percentage changes."
},
"rampingVersionPercentageChangedTime": {
"routingChangedTime": {
"type": "string",
"format": "date-time",
"description": "Last time ramping version percentage was changed.\nIf ramping version is changed, this is also updated, even if the percentage stays the same."
"description": "Last time `current_version_changed_time`, `ramping_version_changed_time, or `ramping_version_percentage`\nof this version changed."
}
}
},
@@ -13745,7 +13745,7 @@
"type": "string",
"format": "date-time"
},
"routingUpdateTime": {
"routingChangedTime": {
"type": "string",
"format": "date-time",
"description": "Last time `current_since_time`, `ramping_since_time, or `ramp_percentage` of this version changed."
8 changes: 4 additions & 4 deletions openapi/openapiv3.yaml
View file
Original file line number Diff line number Diff line change
@@ -9244,11 +9244,11 @@ components:
type: string
description: Last time ramping version was changed. Not updated if only the ramp percentage changes.
format: date-time
rampingVersionPercentageChangedTime:
routingChangedTime:
type: string
description: |-
Last time ramping version percentage was changed.
If ramping version is changed, this is also updated, even if the percentage stays the same.
Last time `current_version_changed_time`, `ramping_version_changed_time, or `ramping_version_percentage`
of this version changed.
format: date-time
Schedule:
type: object
@@ -11182,7 +11182,7 @@ components:
createTime:
type: string
format: date-time
routingUpdateTime:
routingChangedTime:
type: string
description: Last time `current_since_time`, `ramping_since_time, or `ramp_percentage` of this version changed.
format: date-time
8 changes: 4 additions & 4 deletions temporal/api/deployment/v1/message.proto
View file
Original file line number Diff line number Diff line change
@@ -130,7 +130,7 @@ message WorkerDeploymentVersionInfo {
google.protobuf.Timestamp create_time = 3;

// Last time `current_since_time`, `ramping_since_time, or `ramp_percentage` of this version changed.
google.protobuf.Timestamp routing_update_time = 4;
google.protobuf.Timestamp routing_changed_time = 4;

// (-- api-linter: core::0140::prepositions=disabled
// aip.dev/not-precedent: 'Since' captures the field semantics despite being a preposition. --)
@@ -255,7 +255,7 @@ message RoutingInfo {
google.protobuf.Timestamp current_version_changed_time = 4;
// Last time ramping version was changed. Not updated if only the ramp percentage changes.
google.protobuf.Timestamp ramping_version_changed_time = 5;
// Last time ramping version percentage was changed.
// If ramping version is changed, this is also updated, even if the percentage stays the same.
google.protobuf.Timestamp ramping_version_percentage_changed_time = 6;
// Last time `current_version_changed_time`, `ramping_version_changed_time, or `ramping_version_percentage`
// of this version changed.
google.protobuf.Timestamp routing_changed_time = 6;
}
Loading