Add activty type as an option for activity API #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jan 28, 2025
| @@ -1768,8 +1766,18 @@ message UpdateActivityOptionsByIdRequest { | |||
| // Controls which fields from `activity_options` will be applied | |||
| google.protobuf.FieldMask update_mask = 7; | |||
|
|
|||
| // Used to de-dupe requests | |||
| string request_id = 8; | |||
| // either activity id or activity type must be provided | |||
There was a problem hiding this comment.
or type
This doesn't make sense in an UpdateActivityOptionsByIdRequest IMO. This API call as named only makes sense for a single activity by ID. If there are batch needs or a non-ID-specific update, maybe a different API call is needed or this one is improperly named.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
remove acitvity_id as a single option for Activity API.
Now callers can chose to pause/undate/unpause/reset all the pending activities of a certain type.
Why?
Design review feedback.
If multiple activities are running in parallel they are usually of the same type, and experience the same problem.
Breaking changes
No with current implementation.