Mekhanik evgenii/fix bug with access already freed mem #760
+976
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/fix-bug-with-access-already-freed-mem
branch
7 times, most recently
from
3f3abd4 to
e7e74a2
Compare
RomanBelozerov
requested changes
Feb 7, 2025
http_general/test_headers.py
Outdated
| return | ||
|
|
||
| self.assertEqual(server.last_request.headers.get('trailer'), tr1 + " " + tr2) | ||
| if not self.__is_hbp(tr1): |
There was a problem hiding this comment.
Probably you should add checks if trailer is hbp?
http_general/test_headers.py
Outdated
| self, name, method, tr1, tr1_val, tr2, tr2_val, expected_status_code | ||
| ): | ||
| self.start_all_services() | ||
| self.disable_deproxy_auto_parser() |
There was a problem hiding this comment.
Why do you disable the parser?
http_general/test_headers.py
Outdated
| tr1_val="keep-alive", | ||
| tr2="Keep-Alive", | ||
| tr2_val="timeout=5, max=100", | ||
| expected_status_code="200" |
There was a problem hiding this comment.
You should remove expected_status_code from test params. You always use 200.
http_general/test_headers.py
Outdated
Comment on lines
579
to
612
| if not isinstance(client, DeproxyClientH2): | ||
| if method != "HEAD" and not self.__is_hbp(tr1): | ||
| self.assertEqual( | ||
| client.last_response.trailer.get(tr1), | ||
| tr1_val, | ||
| "Moved trailer header value mismatch the original one", | ||
| ) | ||
| else: | ||
| self.assertFalse(client.last_response.trailer.get(tr1)) | ||
| if method != "HEAD" and not self.__is_hbp(tr2): | ||
| self.assertEqual( | ||
| client.last_response.trailer.get(tr2), | ||
| tr2_val, | ||
| "Moved trailer header value mismatch the original one", | ||
| ) | ||
| else: | ||
| self.assertFalse(client.last_response.trailer.get(tr2)) | ||
| self.assertEqual(client.last_response.headers.get("Transfer-Encoding"), "chunked") | ||
| self.assertEqual(client.last_response.headers.get("Trailer"), tr1 + " " + tr2) | ||
| self.assertIsNone(client.last_response.headers.get(tr1)) | ||
| self.assertIsNone(client.last_response.headers.get(tr2)) | ||
| else: | ||
| if method != "HEAD" and not self.__is_hbp(tr1): | ||
| self.assertEqual( | ||
| client.last_response.headers.get(tr1), | ||
| tr1_val, | ||
| "Moved trailer header value mismatch the original one", | ||
| ) | ||
| if method != "HEAD" and not self.__is_hbp(tr2): | ||
| self.assertEqual( | ||
| client.last_response.headers.get(tr2), | ||
| tr2_val, | ||
| "Moved trailer header value mismatch the original one", | ||
| ) |
There was a problem hiding this comment.
Let's add checks like test params. For example:
def assert_HEAD_http2_request(self, response):
self.assertIsNone(response.trailer.get(tr1))
self.assertIsNone(response.trailer.get(tr2))
@marks.Parameterize.expand(
[
marks.Param(
name="no_hbp_GET",
method="GET",
tr1="X-Token1",
tr1_val="value1",
tr2="X-Token2",
tr2_val="value2",
assert_func=assert_HEAD_http2_request,
),
...
]
def test_trailers_in_response(
self, name, method, tr1, tr1_val, tr2, tr2_val, assert_func
...
assert_func(self, client.last_response)
):Also you can move this checks to DeproxyAutoParser, or not?
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/fix-bug-with-access-already-freed-mem
branch
from
e7e74a2 to
9fa396a
Compare
Now Tempesta blocks all bodyless methods requests if body is present (in case of chunked body also). So change method to POST in tests.
Linux reset ipv6 address if we set mtu less then 1500, so we should restore it ater test finished.
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/fix-bug-with-access-already-freed-mem
branch
2 times, most recently
from
678f1f1 to
ba962c8
Compare
EvgeniiMekhanik
force-pushed
the
MekhanikEvgenii/fix-bug-with-access-already-freed-mem
branch
from
ba962c8 to
6e0ff3d
Compare
|
I also think about using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.