Add pgrx 0.13.0 and refactor builder-images.yml #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
theory
added a commit
that referenced
this pull request
Feb 25, 2025
Instead of using explicit `docker` calls in the Trunk builder images workflow, use the docker/build-push-action. This simplifies the configuration a bit. It also will properly use `docker buildx`.
theory
added a commit
that referenced
this pull request
Feb 25, 2025
Instead of using explicit `docker` calls in the Trunk builder images workflow, use the docker/build-push-action. This simplifies the configuration a bit. It also will properly use `docker buildx`.
theory
added a commit
that referenced
this pull request
Feb 25, 2025
Instead of using explicit `docker` calls in the Trunk builder images workflow, use the docker/build-push-action. This simplifies the configuration a bit. It also will properly use `docker buildx`.
theory
force-pushed
the
fix-builds
branch
8 times, most recently
from
b60a0d2 to
e59e1cf
Compare
theory
added a commit
that referenced
this pull request
Feb 26, 2025
Instead of using explicit `docker` calls in the Trunk builder images workflow, use the docker/build-push-action. This simplifies the configuration a bit. It also will properly use `docker buildx`.
theory
added a commit
that referenced
this pull request
Feb 26, 2025
Instead of using explicit `docker` calls in the Trunk builder images workflow, use the docker/build-push-action. This simplifies the configuration a bit. It also will properly use `docker buildx`.
theory
added a commit
that referenced
this pull request
Feb 26, 2025
Instead of using explicit `docker` calls in the Trunk builder images workflow, use the docker/build-push-action. This simplifies the configuration a bit. It also will properly use `docker buildx`.
theory
added a commit
that referenced
this pull request
Feb 26, 2025
Instead of using explicit `docker` calls in the Trunk builder images workflow, use the docker/build-push-action. This simplifies the configuration a bit. It also will properly use `docker buildx`.
theory
added a commit
that referenced
this pull request
Feb 26, 2025
Instead of using explicit `docker` calls in the Trunk builder images workflow, use the docker/build-push-action. This simplifies the configuration a bit. It also will properly use `docker buildx`.
theory
added a commit
that referenced
this pull request
Feb 26, 2025
Instead of using explicit `docker` calls in the Trunk builder images workflow, use the docker/build-push-action. This simplifies the configuration a bit. It also will properly use `docker buildx`.
theory
added a commit
that referenced
this pull request
Feb 26, 2025
Instead of using explicit `docker` calls in the Trunk builder images workflow, use the docker/build-push-action. This simplifies the configuration a bit. It also will properly use `docker buildx`.
Refactor the `builder-images.yml` pipeline to keep local copies of each image and to push them along with the manifest in a separate job that runs only on `main`. This allows the `pgrx` build job to run concurrently with the `c-builder` manifest job (on `main`) and to always build from the just-created `c-builder` image. Use `docker/build-push-action` Instead of using explicit `docker` calls. This simplifies the configuration a bit and properly uses `docker buildx`. Remove the logins to Docker Hub, which are unused. Reformat some of the YAML to be more compact and legible.
vrmiguel
approved these changes
Feb 26, 2025
vrmiguel
pushed a commit
that referenced
this pull request
Mar 6, 2025
Also give the image building workflow some nicer job names and use `docker buildx build` instead of `docker build`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
builder-images.ymlpipeline to keep local copies of each image and to push them along with the manifest in a separate job that runs only onmain. This allows thepgrxbuild job to run concurrently with thec-buildermanifest job (onmain) and to always build from the just-createdc-builderimage.Use
docker/build-push-actionInstead of using explicitdockercalls. This simplifies the configuration a bit and properly usesdocker buildx.Remove the logins to Docker Hub, which are unused.
Reformat some of the YAML to be more compact and legible.