Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(community-modal): #403 fixed heading text overlap with close icon #434

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

manjitsingh88
Copy link
Contributor

Related issues

See #403

Description

  • Fix modal heading text overlap with close icon

Checklist before submitting pull request

  • Commits follow our Developer Guide
  • New code is unit tested
  • make sure visual and accessibility tests pass
  • make sure code builds

##screenshots
Screen Shot 2021-01-14 at 12 45 40 PM

@manjitsingh88 manjitsingh88 requested a review from jraff January 14, 2021 18:26
@TDSBot
Copy link

TDSBot commented Jan 14, 2021

Packages pending updates:

- @tds/community-modal: 1.2.0 => 1.2.1

If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@jraff jraff force-pushed the modal-text-overlap branch from 8ecdc06 to 901982b Compare January 15, 2021 20:05
@mike-bunce
Copy link
Contributor

Embargo exception approved: https://tdrm-285714.ue.r.appspot.com/?id=402292225

@TDSBot
Copy link

TDSBot commented Jan 15, 2021

Packages pending updates:

- @tds/community-modal: 1.2.1 => 1.2.2

If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@jraff jraff merged commit 0765d0d into master Jan 15, 2021
@manjitsingh88 manjitsingh88 deleted the modal-text-overlap branch January 15, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants