feat: Update credentials for Ko Multi-Arch Images

[LiteBrick204]

Changes

This is for #2224
/kind feature

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide
for more details.

[tekton-robot]

Hi @LiteBrick204. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AlanGreene]

Thanks for the PR @LiteBrick204, one small change and this looks good.

[afrittoli]

/ok-to-test

[AlanGreene]

/lgtm

[afrittoli]

There's no need to cat the token to a variable and then echo it.
This is potentially problematic because your using echo and if the shell was ran with -x it would output the token to the log.

Could you please replace those two lines with:

docker login ghcr.io -u ${IMAGE_REGISTRY_USER} --password-stdin <"${IMAGE_REGISTRY_CREDENTIALS}"

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlanGreene, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AlanGreene,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afrittoli]

/lgtm