Set ConfigSource in clusterresolver #5687

chuangw6 · 2022-10-25T21:41:28Z

Changes

/kind feature

Related to #5522

Prior, a field named Source was introduced to ResolutionRequest status to record the source where the remote resource came from. And the individual resolvers need to implement the Source function to set the correct source value. But the method in clusterresolver returns a nil value.

Now, we return correct source value with the 3 subfields: url, digest and entrypoint

url: Kubernetes CRD namespace-scoped resource URI appended with UID.
Example: /apis/GROUP/VERSION/namespaces/NAMESPACE/RESOURCETYPE/NAME@UID.
digest: hex-encoded sha256 checksum of the in-cluster resource
entrypoint: empty because the path is already available in url field.

Signed-off-by: Chuang Wang [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Set source value for cluster resource to link back its origin i.e. url and checksum.

tekton-robot · 2022-10-25T21:46:44Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/cluster/resolver.go	86.2%	87.4%	1.1

tekton-robot · 2022-10-25T21:55:41Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/cluster/resolver.go	86.2%	87.4%	1.1

XinruZhang · 2022-10-28T17:26:16Z

pkg/resolution/resolver/cluster/resolver.go

 		pipeline.Kind = "Pipeline"
-		pipeline.APIVersion = "tekton.dev/v1beta1"
+		pipeline.APIVersion = groupVersion


Out of curiosity, are we also going to support v1 in the remote resolution after V1 release?

Yeah, we will. Basically, this should always be whatever version is used in the PipelineRun reconciler by default, but we should probably add a param for apiVersion to allow overriding that...

Out of curiosity, are we also going to support v1 in the remote resolution after V1 release?

Yeah agreed. We will need to support v1 in remote resolution. Thanks for asking @XinruZhang .

+1 for a new param for apiVersion, it looks like a future refactor work XD

pkg/resolution/resolver/cluster/resolver.go

chuangw6 · 2022-11-01T14:31:24Z

/hold

Since resources in cluster are not in version control which is desired for slsa provenance, the source value might be meaningless. We need more discussions around this.

tekton-robot · 2022-11-01T19:57:37Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/cluster/resolver.go	86.2%	87.4%	1.1

pkg/resolution/resolver/cluster/resolver.go

tekton-robot · 2022-11-04T18:22:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/cluster/resolver.go	86.4%	84.4%	-2.0

tekton-robot · 2022-11-08T20:39:12Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/cluster/resolver.go	86.4%	84.4%	-2.0

chuangw6 · 2022-11-08T20:41:40Z

/retest

abayer · 2022-11-09T13:08:41Z

/approve

wlynch

/lgtm

tekton-robot · 2022-11-09T19:12:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer, wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [abayer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Related to tektoncd#5522 Prior, a field named Source was introduced to ResolutionRequest status to record the source where the remote resource came from. And the individual resolvers need to implement the Source function to set the correct source value. But the method in clusterresolver returns a nil value. Now, we return correct source value with the 3 subfields: url, digest and entrypoint - url: [Kubernetes CRD namespace-scoped resource URI](https://kubernetes.io/docs/reference/using-api/api-concepts/#resource-uris) appended with UID. Example: /apis/GROUP/VERSION/namespaces/NAMESPACE/RESOURCETYPE/NAME@UID. - digest: hex-encoded sha256 checksum of the in-cluster resource - entrypoint: ***empty*** because the path is already available in url field. Signed-off-by: Chuang Wang <[email protected]>

chuangw6 · 2022-11-09T20:05:06Z

Thanks for the lgtm @wlynch.
Sorry. Just resolved conflict with main, which caused lgtm to be removed. 🤣

tekton-robot · 2022-11-09T20:07:41Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/cluster/resolver.go	86.4%	84.4%	-2.0

chuangw6 · 2022-11-09T20:09:42Z

/retest

wlynch

/lgtm

tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 25, 2022

tekton-robot requested review from afrittoli and lbernick October 25, 2022 21:41

tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 25, 2022

chuangw6 force-pushed the source-in-clusterresolver branch from 2dc2d1d to 426e02a Compare October 25, 2022 21:49

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2022

chuangw6 mentioned this pull request Oct 25, 2022

Set Source information in ResolutionRequest #5522

Closed

XinruZhang reviewed Oct 28, 2022

View reviewed changes

abayer requested changes Nov 1, 2022

View reviewed changes

pkg/resolution/resolver/cluster/resolver.go Outdated Show resolved Hide resolved

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2022

chuangw6 marked this pull request as draft November 1, 2022 14:34

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2022

lbernick removed their request for review November 1, 2022 14:46

chuangw6 marked this pull request as ready for review November 1, 2022 19:52

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2022

tekton-robot requested review from jerop and pritidesai November 1, 2022 19:52

Yongxuanzhang reviewed Nov 3, 2022

View reviewed changes

pkg/resolution/resolver/cluster/resolver.go Show resolved Hide resolved

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2022

chuangw6 force-pushed the source-in-clusterresolver branch 2 times, most recently from a4c57fd to d96e214 Compare November 4, 2022 18:17

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2022

chuangw6 force-pushed the source-in-clusterresolver branch from d96e214 to 86fef92 Compare November 4, 2022 18:37

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022

chuangw6 force-pushed the source-in-clusterresolver branch from 3c9a646 to 00dd28a Compare November 8, 2022 20:30

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022

chuangw6 force-pushed the source-in-clusterresolver branch from 00dd28a to 6e74588 Compare November 8, 2022 20:32

chuangw6 requested review from wlynch and removed request for afrittoli, jerop and pritidesai November 8, 2022 20:44

chuangw6 mentioned this pull request Nov 8, 2022

Use SchemeGroupVersion for tekton objects in cluster resolver #5705

Merged

7 tasks

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2022

abayer approved these changes Nov 9, 2022

View reviewed changes

wlynch approved these changes Nov 9, 2022

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2022

chuangw6 force-pushed the source-in-clusterresolver branch from 6e74588 to 765bf8a Compare November 9, 2022 20:02

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2022

chuangw6 requested a review from wlynch November 9, 2022 20:57

wlynch reviewed Nov 10, 2022

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022

tekton-robot merged commit 5557d10 into tektoncd:main Nov 10, 2022

chuangw6 mentioned this pull request Nov 16, 2022

Chains needs to be able to "Identify entry point" - SLSA L3 requirement. tektoncd/chains#521

Closed

chuangw6 mentioned this pull request Nov 29, 2022

Remove predicate.buildConfig.tasks[i].ref field tektoncd/chains#629

Closed

6 tasks

chuangw6 mentioned this pull request Jul 21, 2023

Add checksum of on-cluster resources to Provenance.RefSource #6928

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set ConfigSource in clusterresolver #5687

Set ConfigSource in clusterresolver #5687

chuangw6 commented Oct 25, 2022 •

edited

Loading

tekton-robot commented Oct 25, 2022

tekton-robot commented Oct 25, 2022

XinruZhang Oct 28, 2022

abayer Nov 1, 2022

chuangw6 Nov 1, 2022

XinruZhang Nov 1, 2022

chuangw6 commented Nov 1, 2022

tekton-robot commented Nov 1, 2022

tekton-robot commented Nov 4, 2022

tekton-robot commented Nov 8, 2022

chuangw6 commented Nov 8, 2022

abayer commented Nov 9, 2022

wlynch left a comment

tekton-robot commented Nov 9, 2022

chuangw6 commented Nov 9, 2022 •

edited

Loading

tekton-robot commented Nov 9, 2022

chuangw6 commented Nov 9, 2022

wlynch left a comment

Set ConfigSource in clusterresolver #5687

Set ConfigSource in clusterresolver #5687

Conversation

chuangw6 commented Oct 25, 2022 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Oct 25, 2022

tekton-robot commented Oct 25, 2022

XinruZhang Oct 28, 2022

Choose a reason for hiding this comment

abayer Nov 1, 2022

Choose a reason for hiding this comment

chuangw6 Nov 1, 2022

Choose a reason for hiding this comment

XinruZhang Nov 1, 2022

Choose a reason for hiding this comment

chuangw6 commented Nov 1, 2022

tekton-robot commented Nov 1, 2022

tekton-robot commented Nov 4, 2022

tekton-robot commented Nov 8, 2022

chuangw6 commented Nov 8, 2022

abayer commented Nov 9, 2022

wlynch left a comment

Choose a reason for hiding this comment

tekton-robot commented Nov 9, 2022

chuangw6 commented Nov 9, 2022 • edited Loading

tekton-robot commented Nov 9, 2022

chuangw6 commented Nov 9, 2022

wlynch left a comment

Choose a reason for hiding this comment

chuangw6 commented Oct 25, 2022 •

edited

Loading

chuangw6 commented Nov 9, 2022 •

edited

Loading