-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2e): resolve instability issues in end-to-end tests #2517
Conversation
Hi @l-qing. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1. Avoid misunderstanding the pod as being ready when it is still deleting or in a 0/1 state. 2. Avoid misunderstanding the TektonConfig as being ready when it is still in the process of being reconcile. 3. Add the verification of PVC deletion in the undeploy method. Avoid the creation of a new hub when the old PVC is still in the deleting state, which leads to the failure of starting the new hub.
33cce82
to
3ba08f3
Compare
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
Avoid misunderstanding the pod as being ready
when it is still deleting or in a 0/1 state.
Avoid misunderstanding the TektonConfig as being ready
when it is still in the process of being reconcile.
Add the verification of PVC deletion in the undeploy method.
Avoid the creation of a new hub when the old PVC is still in the
deleting state, which leads to the failure of starting the new hub.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lint
before submitting a PRSee the contribution guide for more details.
Release Notes