Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing icon and styles for PipelineRunPending #1958

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

AlanGreene
Copy link
Member

Changes

Resolves #1944

Add missing status icon on the PipelineRuns page, and missing
styles in the RunHeader on the PipelineRun details page for
a PipelineRun with status PipelineRunPending (introduced in
Tekton Pipelines 0.21).

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Add missing status icon on the PipelineRuns page, and missing
styles in the RunHeader on the PipelineRun details page for
a PipelineRun with status PipelineRunPending (introduced in
Tekton Pipelines 0.21).
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 25, 2021
@tekton-robot tekton-robot requested a review from ziheng February 25, 2021 11:54
Copy link
Member

@steveodonovan steveodonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveodonovan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2021
@ziheng
Copy link

ziheng commented Mar 1, 2021

/lgtm

@tekton-robot tekton-robot merged commit eb08ed1 into tektoncd:master Mar 1, 2021
@AlanGreene AlanGreene deleted the pending_pipelinerun branch March 1, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure PipelineRuns created in pending state are handled correctly
4 participants