Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure PipelineRuns created in pending state are handled correctly #1944

Closed
AlanGreene opened this issue Feb 17, 2021 · 0 comments · Fixed by #1958
Closed

Ensure PipelineRuns created in pending state are handled correctly #1944

AlanGreene opened this issue Feb 17, 2021 · 0 comments · Fixed by #1958
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@AlanGreene
Copy link
Member

AlanGreene commented Feb 17, 2021

Related: tektoncd/pipeline#3522 and docs

Since Tekton Pipelines 0.21 a PipelineRun can be created with status PipelineRunPending and will not begin executing until the status is updated.

To mark a PipelineRun as pending, set .spec.status to PipelineRunPending when creating it:

apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  name: go-example-git
spec:
  # […]
  status: "PipelineRunPending"

To start the PipelineRun, clear the .spec.status field. Alternatively, update the value to PipelineRunCancelled to cancel it.

Verify this is handled correctly in the Dashboard and that we display a suitable status string + icon in this case. This might already be handled by our existing defaults.

@AlanGreene AlanGreene added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Feb 17, 2021
@AlanGreene AlanGreene self-assigned this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant