chore : minor fixes

tekdi · Oct 30, 2024 · e73eed6 · e73eed6
1 parent 1e53cfd
commit e73eed6
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/adapters/postgres/user-adapter.ts b/src/adapters/postgres/user-adapter.ts
@@ -771,7 +771,7 @@ export class PostgresUserService implements IServicelocator {
       const validatedRoles = await this.validateRequestBody(userCreateDto, academicYearId);
 
       // check if roles are invalid and academic year is provided 
-      if (!Array.isArray(validatedRoles) || !validatedRoles.every(role => role instanceof Role) && academicYearId.length) {
+      if ((!Array.isArray(validatedRoles) || !validatedRoles.every(role => role instanceof Role)) && academicYearId?.length) {
         return APIResponse.error(
           response,
           apiId,