Skip to content

Commit

Permalink
fix rules
Browse files Browse the repository at this point in the history
  • Loading branch information
alextekartik committed Nov 25, 2024
1 parent 63194c9 commit df99a0c
Show file tree
Hide file tree
Showing 6 changed files with 32 additions and 2 deletions.
2 changes: 2 additions & 0 deletions idb_shim/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ linter:
rules:
- always_declare_return_types
- avoid_dynamic_calls
- avoid_null_checks_in_equality_operators
- avoid_print
- avoid_slow_async_io
- cancel_subscriptions
Expand All @@ -34,4 +35,5 @@ linter:
- test_types_in_equals
- throw_in_finally
- unawaited_futures
- unintended_html_in_doc_comment
- unnecessary_statements
13 changes: 13 additions & 0 deletions idb_test/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,28 @@ linter:
- avoid_null_checks_in_equality_operators
- avoid_slow_async_io
- cancel_subscriptions
- deprecated_member_use_from_same_package
- directives_ordering
- implicit_reopen
- invalid_case_patterns
- iterable_contains_unrelated_type
- library_names
- list_remove_unrelated_type
- no_adjacent_strings_in_list
- no_literal_bool_comparisons
- no_self_assignments
- omit_local_variable_types
- package_prefixed_library_names
- prefer_const_constructors
- prefer_const_literals_to_create_immutables
- prefer_if_elements_to_conditional_expressions
- prefer_single_quotes
- prefer_void_to_null
- sort_child_properties_last
- test_types_in_equals
- throw_in_finally
- unawaited_futures
- unintended_html_in_doc_comment
- unnecessary_statements
# === doc rules ===
# - public_member_api_docs
1 change: 1 addition & 0 deletions idb_test/lib/sdb_index_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ void simpleDbIndexTest(TestContext ctx) {
}
});
await testStore.add(db, {'field': 1234});
// ignore: omit_local_variable_types
SdbIndexRecordRef<int, SdbModel, int> recordRef = testIndex.record(1234);
var snapshot = (await recordRef.get(db))!;
expect(snapshot.key, 1);
Expand Down
2 changes: 2 additions & 0 deletions idb_test/lib/sdb_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ void simpleDbTest(TestContext ctx) {
expect(key, 1);
var key2 = await testStore.add(db, {'test': 2});
expect(key2, 2);
// ignore: omit_local_variable_types
SdbRecordRef<int, SdbModel> recordRef = testStore.record(key);
// ignore: omit_local_variable_types
SdbRecordSnapshot<int, SdbModel> record = (await recordRef.get(db))!;
expect(record.value, {'test': 1});
expect(record.key, key);
Expand Down
12 changes: 12 additions & 0 deletions repo_support/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,28 @@ linter:
rules:
- always_declare_return_types
- avoid_dynamic_calls
- avoid_null_checks_in_equality_operators
- avoid_slow_async_io
- cancel_subscriptions
- deprecated_member_use_from_same_package
- directives_ordering
- implicit_reopen
- invalid_case_patterns
- iterable_contains_unrelated_type
- list_remove_unrelated_type
- no_adjacent_strings_in_list
- no_literal_bool_comparisons
- no_self_assignments
- omit_local_variable_types
- package_prefixed_library_names
- prefer_const_constructors
- prefer_const_literals_to_create_immutables
- prefer_if_elements_to_conditional_expressions
- prefer_single_quotes
- sort_child_properties_last
- test_types_in_equals
- throw_in_finally
- unawaited_futures
- unintended_html_in_doc_comment
- unnecessary_statements
- use_full_hex_values_for_flutter_colors
4 changes: 2 additions & 2 deletions repo_support/tool/tag.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ Future main() async {
var version = Version.parse((loadYaml(
await File(join('..', 'idb_shim', 'pubspec.yaml')).readAsString())
as Map)['version'] as String);
print('Version $version');
print('Tap anything or CTRL-C: $version');
stdout.writeln('Version $version');
stdout.writeln('Tap anything or CTRL-C: $version');

await sharedStdIn.first;
await shell.run('''
Expand Down

0 comments on commit df99a0c

Please sign in to comment.