teika: use mutable substitutions #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Achieve a much faster typer.
Context
Currently Teika uses a model where substitutions are only dropped when the stack unwinds, this makes so that the substitutions are never overwritten while some term may still reference it, making so that storing them on the stack is not needed, additionally this makes using a mutable array as the substitutions list waaay easier.
This PR switches to using a mutable substitution list, but note that the actual substitutions are "imutable" and only the content can change, this is intentional as the reference to the substs should indicate the length of substs. This is not optimal but is really easy to implement.
Related