fix(instant-chart): default values

teguru-labs · Jul 19, 2024 · e86fbe1 · e86fbe1
1 parent 32c0d3f
commit e86fbe1
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 10 deletions.
diff --git a/charts/instant-chart/Chart.yaml b/charts/instant-chart/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: instant-chart
 description: A Helm chart enables rapid deployment
 type: application
-version: 0.1.1
+version: 0.1.2
 dependencies:
   - name: common
     version: 2.20.5

diff --git a/charts/instant-chart/README.md b/charts/instant-chart/README.md
@@ -78,12 +78,13 @@ See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall/) for command docu
 
 ### Service parameters
 
-| Name                  | Description                                                                | Value       |
-| --------------------- | -------------------------------------------------------------------------- | ----------- |
-| `service.enabled`     | Specifies whether a service should be created.                             | `true`      |
-| `service.type`        | The type of the service (ClusterIP, NodePort, LoadBalancer, ExternalName). | `ClusterIP` |
-| `service.ports`       | The ports that the service should expose.                                  |             |
-| `service.annotations` | Annotations to add to the service.                                         | `{}`        |
+| Name                   | Description                                                                | Value       |
+| ---------------------- | -------------------------------------------------------------------------- | ----------- |
+| `service.enabled`      | Specifies whether a service should be created.                             | `true`      |
+| `service.type`         | The type of the service (ClusterIP, NodePort, LoadBalancer, ExternalName). | `ClusterIP` |
+| `service.ports`        | The ports that the service should expose.                                  |             |
+| `service.annotations`  | Annotations to add to the service.                                         | `{}`        |
+| `service.externalName` | Set external name when using ExternalName Service                          | `{}`        |
 
 ### Ingress parameters
 

diff --git a/charts/instant-chart/values.yaml b/charts/instant-chart/values.yaml
@@ -39,9 +39,7 @@ replicas: 1
 ##         mountPath: "/data"
 ##         subPath: "my-subpath"
 ##         readOnly: true
-# containers: []
-containers:
-  - image: nginx
+containers: []
 
 ## Additional initialization containers
 ##
@@ -162,6 +160,11 @@ service:
   ##
   annotations: {}
 
+  ## Add additional fields to the service spec: externalName, externalIPs, .etc.
+  ##
+  ## externalName: ""
+  ## externalIPs: []
+
 ## Ingress configuration
 ## ref https://kubernetes.io/docs/concepts/services-networking/ingress
 ##