Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to keep SimpleTypes #935

Closed

Conversation

untereiner
Copy link

📒 Description

Allow to keep simpleTypes via the Config file

Resolves #692

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

@untereiner untereiner changed the title change config settings Allow to keep SimpleTypes Feb 7, 2024
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1e5502) 100.00% compared to head (8bd754c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #935   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         8768      8775    +7     
  Branches      2082      2084    +2     
=========================================
+ Hits          8768      8775    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@untereiner
Copy link
Author

@tefra Am I on a good track by modifying config settings to introduce the simpleTypes to keep ?

@tefra
Copy link
Owner

tefra commented Mar 8, 2024

@tefra Am I on a good track by modifying config settings to introduce the simpleTypes to keep ?

@untereiner yes

@tefra
Copy link
Owner

tefra commented Mar 9, 2024

Please reopen when you are ready

@tefra tefra closed this Mar 9, 2024
@untereiner
Copy link
Author

untereiner commented Mar 12, 2024

@tefra I am not able to go further. I don't understand where the simpleTypes are catched and where I could filter them.
Could you help me, or point me where I have to look ?

  • I think it is in one of the handlers of the FLATTEN step.
  • Also reset_attribute_type and copy_attribute_properties have similar behavior

@tefra
Copy link
Owner

tefra commented Mar 25, 2024

Please take a look at this branch, it's not complete, 74 tests fail in w3c-test-suite but it should give you some idea on how to proceed.

https://github.com/tefra/xsdata/tree/generate-simple-types

I am afraid I have other priorities to finish this one and I won't accept contributions that break the w3c-test-suite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to explicitly create SimpleType classes
2 participants