Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use substitution groups for compound field names only when all elements are derived from one #905

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

tefra
Copy link
Owner

@tefra tefra commented Dec 31, 2023

📒 Description

The new option to use the substitution groups to name the compound fields is confusing when repeatable choices are mixed with substitution groups.

This pr enforces the new field naming pattern only when all elements are part of a substitution group

Resolves #904

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa05d61) 100.00% compared to head (bec3902) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #905   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         8728      8728           
  Branches      2067      2067           
=========================================
  Hits          8728      8728           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra tefra merged commit 5a4883d into main Dec 31, 2023
14 checks passed
@tefra tefra deleted the fix-904 branch December 31, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New substitution group code opportunities
1 participant