Handle parsing mandatory byte elements with no value #873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
Fixes parsing of empty mandatory byte elements to produce a byte string instead of a unicode string.
Resolves #872
🔗 What I've Done
Adds special handling to the
PrimitiveNode.bind()
method if the incoming type is bytes.💬 Comments
An alternative solution here might be to iterate through the list of incoming types (
self.var.types
) and attempt to construct a default value. However I'm not aware of any cases other than strings or bytes where this method would be called, so it may be overkill.🛫 Checklist