Fix json binding with union fields #864
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
xsdata's converter is really designed to work with string values from xml, in case of json with union fields like
Union[bool, int, float]
the parser will convert by accident float values to int or int values to boolResolves #862
🔗 What I've Done
It's not a pretty solution but use the convert to convert everything back to string, we could use the parse_int, parse_float of the
json.loads
but that would mean we are breaking compatibility with other json libraries.💬 Comments
🛫 Checklist