Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement --dry for mrack plugin #3460

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Implement --dry for mrack plugin #3460

wants to merge 5 commits into from

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented Jan 10, 2025 •
edited
Loading

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@skycastlelily skycastlelily mentioned this pull request Jan 10, 2025
Open
@skycastlelily skycastlelily added the ci | full test Pull request is ready for the full test execution label Jan 13, 2025
@skycastlelily skycastlelily added this to the 1.42 milestone Jan 13, 2025
psss
psss reviewed Jan 14, 2025
View reviewed changes
tmt/steps/provision/mrack.py Outdated Show resolved Hide resolved
happz
happz reviewed Jan 20, 2025
View reviewed changes
tmt/steps/provision/mrack.py Outdated Show resolved Hide resolved
@thrix thrix requested review from psss and happz January 21, 2025 01:21
thrix
thrix requested changes Jan 21, 2025
View reviewed changes
tmt/steps/provision/mrack.py Outdated Show resolved Hide resolved
happz
happz reviewed Jan 21, 2025
View reviewed changes
tmt/steps/provision/mrack.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz left review comments

@thrix thrix thrix requested changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

@psss psss Awaiting requested review from psss psss is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution
Projects
None yet
Milestone
1.42
Development

Successfully merging this pull request may close these issues.
4 participants
@skycastlelily @happz @thrix @psss