Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the new core key author #3406

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Implement the new core key author #3406

merged 5 commits into from
Jan 28, 2025

Conversation

psss
Copy link
Collaborator

@psss psss commented Dec 5, 2024

To be used for tracking the information about the original author of the test, plan or story.

Pull Request Checklist

  • implement the feature
  • extend the test coverage
  • update the specification
  • modify the json schema
  • mention the version
  • include a release note

Related: https://issues.redhat.com/browse/TT-227

@psss psss added this to the 1.41 milestone Dec 5, 2024
@psss psss added specification Metadata specification (core, tests, plans, stories) code | core Implementation of the core metadata level labels Jan 9, 2025
@happz happz modified the milestones: 1.41, 1.42 Jan 13, 2025
spec/core/author.fmf Outdated Show resolved Hide resolved
@thrix
Copy link
Collaborator

thrix commented Jan 21, 2025

@psss I would expect an update of the json schemas?

@psss psss requested a review from martinhoyer as a code owner January 21, 2025 14:59
@psss
Copy link
Collaborator Author

psss commented Jan 22, 2025

@psss I would expect an update of the json schemas?

Yeah, that part is covered, together with the implementation itself, in 1646638.

@psss psss requested a review from thrix January 22, 2025 08:46
@psss psss added the ci | full test Pull request is ready for the full test execution label Jan 22, 2025
@psss
Copy link
Collaborator Author

psss commented Jan 22, 2025

Now the implementation should be complete, @skycastlelily, @therazix, could you please re-review?

@skycastlelily
Copy link
Collaborator

1.schemas/discover/shell.yaml deserves an update.
2. you'd better also extend story/show/test.sh plan/show/test.sh
3. you may also want to update tmt/export/polarion.py and export/nitrate.py

@psss psss added the priority | should medium priority, should be included in the next release label Jan 24, 2025
@psss
Copy link
Collaborator Author

psss commented Jan 24, 2025

1.schemas/discover/shell.yaml deserves an update.

Ah, completely missed that one. Good catch! Added in 8be6872.

  1. you'd better also extend story/show/test.sh plan/show/test.sh

Good idea, I've extended plan and story tests as well.

  1. you may also want to update tmt/export/polarion.py and export/nitrate.py

I don't think it's necessary to export this field to polarion or nitrate. Let's added it later if there is a clear user need.

Copy link
Collaborator

@KwisatzHaderach KwisatzHaderach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to add a commit for polarion export, but found out the author field there is fixed to whoever executed the export and can't be changed in any way.

@psss psss added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jan 27, 2025
@thrix
Copy link
Collaborator

thrix commented Jan 28, 2025

/packit retest-failed

@thrix thrix disabled auto-merge January 28, 2025 18:55
@thrix thrix merged commit 40591e1 into main Jan 28, 2025
5 of 19 checks passed
@thrix thrix deleted the author branch January 28, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution code | core Implementation of the core metadata level priority | should medium priority, should be included in the next release specification Metadata specification (core, tests, plans, stories) status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants