-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add favicon to tmt docs #3021
Add favicon to tmt docs #3021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the improvement. Thinking a bit about the icon size: Currently the image is 700x700 and the size is 432K, so the icon is larger then the page content :) But it will be cached, I guess, so probably not worth it?
It will be cached for sure, and we definitely can create a smaller one :) |
Ok :) Adding here: teemtee/docs#5 |
@psss done. |
Documentation-only, not waiting for functional tests to complete. |
hah, I totally missed this and doing the same lol. @psss is the logo available in other formats or gimp files? @happz you're using way to large resolution for the favicon here I'm afraid. Also not sure if all browsers are happy when it's not |
|
@martinhoyer Yeah, I didn't bother, I wouldn't even notice the image looks a bit weird on my screen. I guess it's like the sound quality, at some point my human ear don't hear the difference :) |
/me hiding his audio equipment 👀 |
Pull Request Checklist