-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose actual guest HW description in guest topology #2586
base: main
Are you sure you want to change the base?
Conversation
6606bbd
to
c7ab83a
Compare
/packit build |
c7ab83a
to
0de684c
Compare
aff4962
to
e9ed8b4
Compare
0101b5e
to
57db8dc
Compare
c1c72c9
to
fbaa944
Compare
fbaa944
to
54bedc4
Compare
In tmt-test-topology-Get-guest-data-default-0.yaml, I get something like this :
Why |
It is included by default. The value of each requirement consists of the actual value, One thing that's wrong though, it should be |
Related to #2402. The patch bootstraps `hardware` field in the guest topology content, and populates it it very basic content. Extending it with more info, e.g. `disk` or `system`, will be task for future patches.
54bedc4
to
e5164ab
Compare
@@ -113,7 +113,7 @@ description: | | |||
TMT_ROLES[role2]="guestN ..." | |||
... | |||
|
|||
.. versionadded:: 1.31 | |||
.. versionadded:: 1.33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next milestone is 1.34?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, and it seems we're not going to make that one either :/
Leaving this comment open till the PR gets ready for merge & reviewed.
Related to #2402. The patch
bootstraps
hardware
field in the guest topology content, and populatesit it very basic content. Extending it with more info, e.g.
disk
orsystem
, will be task for future patches.Pull Request Checklist